Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improved tracing for courier #4226

Merged
merged 2 commits into from
Dec 23, 2024
Merged

feat: improved tracing for courier #4226

merged 2 commits into from
Dec 23, 2024

Conversation

alnr
Copy link
Contributor

@alnr alnr commented Nov 26, 2024

No description provided.

@alnr alnr self-assigned this Nov 26, 2024
@aeneasr
Copy link
Member

aeneasr commented Dec 3, 2024

@aeneasr
Copy link
Member

aeneasr commented Dec 20, 2024

@alnr could you fix the build please?

@alnr alnr force-pushed the alnr/courier-tracing branch from 8225a23 to 19f3aa8 Compare December 23, 2024 11:59
@alnr alnr force-pushed the alnr/courier-tracing branch from 19f3aa8 to 4004927 Compare December 23, 2024 12:06
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.57%. Comparing base (d9f6f75) to head (4004927).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
courier/smtp_channel.go 95.45% 0 Missing and 1 partial ⚠️
identity/extension_verification.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4226      +/-   ##
==========================================
- Coverage   78.61%   78.57%   -0.05%     
==========================================
  Files         381      381              
  Lines       27318    27346      +28     
==========================================
+ Hits        21476    21486      +10     
- Misses       4223     4237      +14     
- Partials     1619     1623       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alnr alnr merged commit 85a7071 into master Dec 23, 2024
29 checks passed
@alnr alnr deleted the alnr/courier-tracing branch December 23, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants