-
Notifications
You must be signed in to change notification settings - Fork 974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add verification hook to login flow #3829
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3829 +/- ##
==========================================
+ Coverage 77.95% 77.96% +0.01%
==========================================
Files 358 358
Lines 25165 25186 +21
==========================================
+ Hits 19617 19636 +19
- Misses 4041 4043 +2
Partials 1507 1507 ☔ View full report in Codecov by Sentry. |
r = r.WithContext(ctx) | ||
defer otelx.End(span, &err) | ||
if f.RequestedAAL != identity.AuthenticatorAssuranceLevel1 { | ||
span.AddEvent("Skipping verification hook because AAL is not 1") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need an event for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't really know how else to allow making this case visible in the trace. An event is great, because it shows up as part of the span.
Related issue(s)
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
Further Comments