added AuthConfigs to BuildOptions and pass that to BuildImage #488
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please consider this a 'naive PR' - we ran into an issue where although it was possible to pass along authentication to the run commands but not the build.
This fixes it, but I'm wondering why this wasn't already possible or whether I'm doing something else wrong
And i'm wondering why
dockertest
did not use already present and logged in~/.docker/config.json
Either way, thanks for
dockertest
, it has already been used tens of thousands of times by us :)