Fixed work. this refs #4 #5
Conversation
|
To check this work, the reviewer can use the IPTS-26894 and one particular run that has the issue Switch to the right conda environment cd to git and this repo add to python path create tmp output folder run reduction if the tif files show up in the ~/tmp folder, it worked. |
| @@ -131,7 +138,7 @@ def correct_images( | |||
| import os | |||
|
|
|||
| _file_root = os.path.dirname(os.path.abspath(__file__)) | |||
| test_data_dir = os.path.join(_file_root, "../data") | |||
| test_data_dir = os.path.join(_file_root, "../../../../NeutronImagingScripts/data") | |||
There was a problem hiding this comment.
not sure why the relative path changed, but it should not affect using the functions.
| # in some rare instances, the MCP creates a duplicate set of the run in the same folder | ||
| # we need to only consider the first set in the autoreduction |
There was a problem hiding this comment.
If this is something that occurs very often, we should have a pre-processing to handle the duplicates.
As a quick fix, these changes are okay.
I would recommend writing a new defect/story to address this properly.
No description provided.