Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix effectively ignored XML parameters for SZ operator #4404

Merged
merged 3 commits into from
Dec 17, 2024

Conversation

gregorweiss
Copy link
Contributor

Fixes the problem of ignored parameters from XML file for the SZ operator.

Problem:
The keys in m_Parameter are forced to lower case formatting during Operator construction. Hence, previous checks for corresponding parameters in CompressSZ.cpp always failed, such that parameters set via an XML configuration were effectively ignored.

Solution:
Without changing the enforced lower case formatting in Operator construction, avoiding possible side-effects, and not knowing the reasons for lower case formatting, the current PR suggests the most direct fix in OperatorSZ.cpp.

@eisenhauer eisenhauer merged commit f80ad82 into ornladios:master Dec 17, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants