Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: find branchs in chrono order #3666

Closed
wants to merge 45 commits into from
Closed
Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
eff1b1b
BP5: fixes memory error with IBM XL
vicentebolea May 10, 2023
f1cedf3
Merge pull request #3619 from vicentebolea/backports-bp5-bugfix
vicentebolea May 29, 2023
457d8e2
Merge pull request #3623 from vicentebolea/kokkos-use-nvcc-wrapper
vicentebolea May 17, 2023
72e430c
ci,ascent: enable ascent builds
vicentebolea May 5, 2023
6bbf433
ci,olcf,crusher: enable Crusher CI
vicentebolea May 12, 2023
55fe563
ci,crusher: minor tweaks
vicentebolea May 25, 2023
86b792f
docs: update whatsnew
vicentebolea May 25, 2023
4e640c1
Bump requests from 2.28.1 to 2.31.0 in /docs
dependabot[bot] May 23, 2023
be4fcbc
CI,windows: change MSMPI URL
vicentebolea May 22, 2023
bc04804
fixed https://github.com/ornladios/ADIOS2/issues/3638
guj May 26, 2023
c55cf75
crusher,ci: set unique env per pipeline
vicentebolea May 29, 2023
3bd4cff
Merge pull request #3643 from vicentebolea/backports-from-master
vicentebolea May 30, 2023
32eb32b
Allow Span in files opened for Append
eisenhauer Jun 8, 2023
7bd34be
Merge pull request #3657 from eisenhauer/SpanAppend
eisenhauer Jun 8, 2023
b395e8f
ci: find branchs in chrono order
vicentebolea Jun 30, 2023
6277f97
Fix: std::min w/ windows.h in C-Blosc2
ax3l Jul 1, 2023
12c4319
Merge pull request #3681 from ax3l/fix-blosc2-windows-min
eisenhauer Jul 2, 2023
e0f9dc0
enet 2023-06-08 (f93beb4e)
Jun 8, 2023
74eebf7
Merge branch 'upstream-enet' into BP5
eisenhauer Jul 2, 2023
298e38a
EVPath 2023-06-10 (e9be8e63)
Jun 10, 2023
9c455f6
Merge branch 'upstream-EVPath' into BP5
eisenhauer Jul 2, 2023
6535ef9
atl 2023-06-07 (f3c23577)
Jun 7, 2023
86c328a
Merge branch 'upstream-atl' into BP5
eisenhauer Jul 2, 2023
1e45542
ffs 2023-06-06 (46d79432)
Jun 6, 2023
324febb
Merge branch 'upstream-ffs' into BP5
eisenhauer Jul 2, 2023
20afb0e
dill 2023-06-09 (6c94efb3)
Jun 9, 2023
5023da9
Merge branch 'upstream-dill' into BP5
eisenhauer Jul 2, 2023
8ea624a
Tweaks for BP5 on Windows
eisenhauer Jul 2, 2023
e08dba0
String fix and timeout
eisenhauer Jul 3, 2023
9785b9a
Merge pull request #3682 from eisenhauer/BP5
eisenhauer Jul 3, 2023
06ca9cf
Merge branch 'release_29'
vicentebolea Jul 3, 2023
537405d
Merge pull request #3681 from ax3l/fix-blosc2-windows-min
eisenhauer Jul 2, 2023
1b99c8c
Merge release_29
vicentebolea Jul 3, 2023
6917bf9
Fix memory leak when there are Joined Arrays in streaming mode
eisenhauer May 10, 2023
68b282c
Merge pull request #3684 from eisenhauer/FixLeak
eisenhauer Jul 3, 2023
defc1c7
Merge pull request #3673 from vicentebolea/disable-ascent-install-test
vicentebolea Jun 29, 2023
43ae62c
Merge pull request #3650 from ornladios/dependabot/pip/docs/cryptogra…
vicentebolea Jun 14, 2023
af34a40
Merge pull request #3652 from guj/unistd-windows
guj Jun 5, 2023
ce73176
Merge pull request #3684 from eisenhauer/FixLeak
eisenhauer Jul 3, 2023
5e1f9f5
Merge pull request #3685 from vicentebolea/backports_release_29
vicentebolea Jul 4, 2023
ec7d094
Merge branch 'release_29'
vicentebolea Jul 4, 2023
55dc9b2
Merge pull request #3657 from eisenhauer/SpanAppend
eisenhauer Jun 8, 2023
9318869
Fix for the issue #3646. It looks like the default for macos and pyth…
dmitry-ganyushin Jul 4, 2023
c8c5238
Merge pull request #3687 from dmitry-ganyushin/i3646-mult-macos
eisenhauer Jul 4, 2023
b8b4ac0
Merge pull request #3666 from vicentebolea/ci-crusher-tweaks
vicentebolea Jul 5, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ certifi==2022.12.7
cffi==1.15.1
charset-normalizer==2.1.1
colorama==0.4.6
cryptography==39.0.1
cryptography==41.0.0
docutils==0.17
funcparserlib==1.0.1
idna==3.4
Expand Down
6 changes: 6 additions & 0 deletions scripts/ci/cmake-v2/ci-ascent-common.cmake
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# Client maintainer: vicente.bolea@kitware.com

set(CTEST_TEST_ARGS
PARALLEL_LEVEL 8
EXCLUDE ".*/BPWRCUDA.ADIOS2BPCUDAWrong/.*BP4.Serial|.*/BPWRCUDA.ADIOS2BPCUDAMemSel/.*BP4.Serial|Engine.Staging.TestThreads.*|Install.*"
)
5 changes: 1 addition & 4 deletions scripts/ci/cmake-v2/ci-ascent-cuda.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,7 @@ CMAKE_DISABLE_FIND_PACKAGE_FLEX=ON
CMAKE_Fortran_FLAGS:STRING=-Wall
")

set(CTEST_TEST_ARGS
PARALLEL_LEVEL 8
EXCLUDE ".*/BPWRCUDA.ADIOS2BPCUDAWrong/.*BP4.Serial|.*/BPWRCUDA.ADIOS2BPCUDAMemSel/.*BP4.Serial"
)
set(CTEST_CMAKE_GENERATOR "Ninja")
list(APPEND CTEST_UPDATE_NOTES_FILES "${CMAKE_CURRENT_LIST_FILE}")
include(${CMAKE_CURRENT_LIST_DIR}/ci-ascent-common.cmake)
include(${CMAKE_CURRENT_LIST_DIR}/ci-common.cmake)
5 changes: 1 addition & 4 deletions scripts/ci/cmake-v2/ci-ascent-kokkos-cuda.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,7 @@ CMAKE_DISABLE_FIND_PACKAGE_BISON=ON
CMAKE_DISABLE_FIND_PACKAGE_FLEX=ON
")

set(CTEST_TEST_ARGS
PARALLEL_LEVEL 8
EXCLUDE ".*/BPWRCUDA.ADIOS2BPCUDAWrong/.*BP4.Serial|.*/BPWRCUDA.ADIOS2BPCUDAMemSel/.*BP4.Serial|Engine.Staging.TestThreads.*"
)
set(CTEST_CMAKE_GENERATOR "Ninja")
list(APPEND CTEST_UPDATE_NOTES_FILES "${CMAKE_CURRENT_LIST_FILE}")
include(${CMAKE_CURRENT_LIST_DIR}/ci-ascent-common.cmake)
include(${CMAKE_CURRENT_LIST_DIR}/ci-common.cmake)
5 changes: 1 addition & 4 deletions scripts/ci/cmake-v2/ci-ascent-nvhpc.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,7 @@ CMAKE_DISABLE_FIND_PACKAGE_FLEX=ON
CMAKE_NINJA_FORCE_RESPONSE_FILE=OFF
")

set(CTEST_TEST_ARGS
PARALLEL_LEVEL 8
EXCLUDE ".*/BPWRCUDA.ADIOS2BPCUDAWrong/.*BP4.Serial|.*/BPWRCUDA.ADIOS2BPCUDAMemSel/.*BP4.Serial|Install.*Fortran"
)
set(CTEST_CMAKE_GENERATOR "Unix Makefiles")
list(APPEND CTEST_UPDATE_NOTES_FILES "${CMAKE_CURRENT_LIST_FILE}")
include(${CMAKE_CURRENT_LIST_DIR}/ci-ascent-common.cmake)
include(${CMAKE_CURRENT_LIST_DIR}/ci-common.cmake)
2 changes: 1 addition & 1 deletion scripts/ci/cmake-v2/ci-ascent-xl.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ CMAKE_DISABLE_FIND_PACKAGE_FLEX=ON
")

set(NCPUS 4)
set(CTEST_TEST_ARGS PARALLEL_LEVEL 8)
set(CTEST_CMAKE_GENERATOR "Ninja")
list(APPEND CTEST_UPDATE_NOTES_FILES "${CMAKE_CURRENT_LIST_FILE}")
include(${CMAKE_CURRENT_LIST_DIR}/ci-ascent-common.cmake)
include(${CMAKE_CURRENT_LIST_DIR}/ci-common.cmake)
10 changes: 8 additions & 2 deletions source/adios2/toolkit/format/bp5/BP5Deserializer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -707,7 +707,7 @@ void BP5Deserializer::InstallMetaData(void *MetadataBlock, size_t BlockLen,
m_JoinedDimenOffsetArrays = new std::vector<void *>();
m_JoinedDimenOffsetArrays->resize(writerCohortSize);
JoinedDimArray[Step] = m_JoinedDimenOffsetArrays;
m_FreeableMBA = nullptr;
m_FreeableJDOA = nullptr;
}
}
else
Expand All @@ -725,7 +725,7 @@ void BP5Deserializer::InstallMetaData(void *MetadataBlock, size_t BlockLen,
if (!m_JoinedDimenOffsetArrays)
{
m_JoinedDimenOffsetArrays = new std::vector<void *>();
m_FreeableMBA = m_JoinedDimenOffsetArrays;
m_FreeableJDOA = m_JoinedDimenOffsetArrays;
}
if (writerCohortSize > m_JoinedDimenOffsetArrays->size())
{
Expand Down Expand Up @@ -2001,7 +2001,13 @@ BP5Deserializer::~BP5Deserializer()
delete VarRec.second;
}
if (m_FreeableMBA)
{
delete m_FreeableMBA;
}
if (m_FreeableJDOA)
{
delete m_FreeableJDOA;
}
for (auto &step : MetadataBaseArray)
{
delete step;
Expand Down
1 change: 1 addition & 0 deletions source/adios2/toolkit/format/bp5/BP5Deserializer.h
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,7 @@ class BP5Deserializer : virtual public BP5Base
/* We assume operators are not thread-safe, call Decompress() one at a time
*/
std::mutex mutexDecompress;
std::vector<void *> *m_FreeableJDOA = nullptr;
};

} // end namespace format
Expand Down
12 changes: 12 additions & 0 deletions source/h5vol/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,18 @@ if(CMAKE_C_COMPILER_ID MATCHES "^(GNU)$")
string(APPEND CMAKE_C_FLAGS " -Wno-format-zero-length")
endif()

include(CheckIncludeFiles)
check_include_files(unistd.h HAVE_UNISTD_H)
check_include_files(windows.h HAVE_WINDOWS_H)

if (HAVE_UNISTD_H)
add_definitions(-DHAVE_UNISTD_H)
endif()

if (HAVE_WINDOWS_H)
add_definitions(-DHAVE_WINDOWS_H)
endif()

add_library(adios2_h5vol
H5VolReadWrite.c
H5Vol.c
Expand Down
7 changes: 7 additions & 0 deletions source/h5vol/H5VolReadWrite.c
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,14 @@
#include "H5VolReadWrite.h"

#include "H5VolUtil.h"

#ifdef HAVE_UNISTD_H
#include <unistd.h> // sleep
#elif defined HAVE_WINDOWS_H
#include <windows.h>
#define sleep(x) Sleep(1000 * (x))
#endif

// these are in h5private.h
#define SUCCEED 1
#define FAIL 0
Expand Down