Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H5 subfile support #3530

Merged
merged 17 commits into from
Mar 21, 2023
Merged

H5 subfile support #3530

merged 17 commits into from
Mar 21, 2023

Conversation

guj
Copy link
Contributor

@guj guj commented Mar 10, 2023

If H5 has subfile support, it will be the default to write H5 files.

Use envs to control subfile parameters through the underlying HDF5 library:
(# of subfiles per node) H5FD_SUBFILING_IOC_PER_NODE
H5FD_SUBFILING_STRIPE_SIZE

etc.

@guj guj requested a review from vicentebolea as a code owner March 10, 2023 23:05
eisenhauer
eisenhauer previously approved these changes Mar 13, 2023
@anagainaru
Copy link
Contributor

@guj Do you mind cleaning the history before merging so if we ever have to look back at this it will be easier to find the commits?

@guj
Copy link
Contributor Author

guj commented Mar 15, 2023

@guj Do you mind cleaning the history before merging so if we ever have to look back at this it will be easier to find the commits?

Never done that. What commands do you use?

pnorbert
pnorbert previously approved these changes Mar 21, 2023
@anagainaru anagainaru changed the base branch from master to release_29 March 21, 2023 19:13
@anagainaru anagainaru merged commit 4a59197 into ornladios:release_29 Mar 21, 2023
@anagainaru anagainaru added this to the v2.9.0 milestone Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants