Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: do not install empty sst dirs #3501

Merged

Conversation

vicentebolea
Copy link
Collaborator

@vicentebolea vicentebolea commented Feb 22, 2023

Fixes: #3205

Ideally we want to have an install test that fails when it sees empty dirs in the installation tree.

caitlinross
caitlinross previously approved these changes Feb 22, 2023
@vicentebolea vicentebolea changed the base branch from master to release_29 February 22, 2023 16:42
@vicentebolea vicentebolea dismissed caitlinross’s stale review February 22, 2023 16:42

The base branch was changed.

@vicentebolea vicentebolea force-pushed the stop-installing-empty-dirs branch from cb254aa to b27e761 Compare February 22, 2023 16:42
@vicentebolea vicentebolea force-pushed the stop-installing-empty-dirs branch from b27e761 to 66053ae Compare February 22, 2023 17:53
@vicentebolea vicentebolea merged commit 267641a into ornladios:release_29 Feb 22, 2023
@vicentebolea vicentebolea deleted the stop-installing-empty-dirs branch February 22, 2023 20:28
vicentebolea added a commit that referenced this pull request Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.8.0 installs empty directories include/adios2/toolkit/sst/dp and include/adios2/toolkit/sst/util
2 participants