clang-format: format cu files #3011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20ad1d4 to
d07587c
Compare
|
ping @chuckatkins |
|
#3013 is using the previous style for the cuda example file. Just something to consider when we merge the two PRs |
|
@anagainaru yes, this should then go first to master, and later after you rebase you can call this script ( |
|
@vicentebolea Or you could remove the updates to the cuda file from this PR, what is really needed is only the style file |
|
@anagainaru the problem with that is that then this Pull request CI format test will not pass. |
|
you could do a rebase with -Xours to default to my changes here in case of conflict to resolve the conflicts. |
JasonRuonanWang
approved these changes
Jan 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested that this still format C,C++ files by intentionally adding a commit which introduce format mistakes. The checks for that commit is here:
https://github.com/ornladios/ADIOS2/pull/3011/checks?sha=20ad1d499df3b051d0543bce71c7b3c4a717cfbb