Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bp2h5: Use copy instead of symlinks because of windows #2583

Merged
merged 1 commit into from
Jan 13, 2021

Conversation

chuckatkins
Copy link
Contributor

Fixes #2582

@chuckatkins
Copy link
Contributor Author

@ax3l does this fix the issue for you?

@chuckatkins chuckatkins self-assigned this Jan 13, 2021
@chuckatkins chuckatkins added area: build Build issues bug triage: high This issue is a blocker and has to be addressed before the next release or milestone labels Jan 13, 2021
@chuckatkins
Copy link
Contributor Author

I've setup a 2.7.1 patch release to include any bug fixes we may encounter over the next 2w as the release roll out propagates.

@chuckatkins chuckatkins merged commit 6e49423 into ornladios:release_27 Jan 13, 2021
@chuckatkins chuckatkins deleted the fix-bp2h5-on-windows branch January 13, 2021 19:55
chuckatkins pushed a commit that referenced this pull request Jan 13, 2021
bp2h5: Use copy instead of symlinks because of windows
@ax3l
Copy link
Contributor

ax3l commented Jan 13, 2021

Thank you @chuckatkins! Applying the patch in conda-forge/adios2-feedstock#24 to see if this addresses this.

@ax3l
Copy link
Contributor

ax3l commented Jan 14, 2021

does this fix the issue for you?

@chuckatkins yes, the builds ran now, looking great! thanks again! 🚀 ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: build Build issues bug triage: high This issue is a blocker and has to be addressed before the next release or milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants