Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added common-staging tests back for SSC #1847

Closed
wants to merge 1 commit into from
Closed

added common-staging tests back for SSC #1847

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions testing/adios2/engine/staging-common/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,3 +288,14 @@ if(NOT MSVC AND ADIOS2_HAVE_HDF5) # not on windows and only if we have HDF5
add_common_test(${test} HDF5)
endforeach()
endif()

#
# Setup tests for SSC engine
#
if(ADIOS2_HAVE_SSC AND ADIOS2_HAVE_MPI)
set(SSC_TESTS "1x1;1x1.Attrs;1x2;")
foreach(test ${SSC_TESTS})
add_common_test(${test} SSC)
endforeach()
endif()

17 changes: 10 additions & 7 deletions testing/adios2/engine/staging-common/TestCommonReadAttrs.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,16 +293,19 @@ TEST_F(CommonReadTest, ADIOS2CommonRead1D8)
TimeGapDetected++;
}

if (TimeGapExpected)
{
EXPECT_TRUE(TimeGapDetected);
}
else
if (!IgnoreTimeGap)
{
if (TimeGapExpected)
{
EXPECT_TRUE(TimeGapDetected);
}
else
{
EXPECT_FALSE(TimeGapDetected);
}
EXPECT_EQ(t, NSteps);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you move the "EXPECT_EQ(t, NSteps)" outside the "if (!IgnoreTimeGap)" to make sure we're checking that we got all the expected steps (even if we're ignoring writer side test delays).


EXPECT_FALSE(TimeGapDetected);
}

// Close the file
engine.Close();
}
Expand Down