Add Sendable Conformance to Field and Reference Types #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes the Field<C> property wrapper Sendable-compliant to better support concurrent operations and Swift's actor isolation system.
- Remove direct Sendable conformance from Field struct - Add conditional Sendable conformance via extension where C: Sendable
Joannis
approved these changes
Dec 1, 2024
Joannis
approved these changes
Dec 1, 2024
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added Sendable conformance to Field and Reference types for improved thread safety and compatibility with concurrent Swift contexts:
Motivation and Context
This change ensures compatibility with
Sendablerequirements in Swift's concurrency model, addressing thread-safety concerns for asynchronous use cases. No breaking changes are introduced.How Has This Been Tested?
Sendablebehavior.FieldandReferencetypes to confirm no adverse impact on existing functionality.Checklist: