Support an SSH (SFTP) server #16
Conversation
| func channelRead(context: ChannelHandlerContext, data: NIOAny) { | ||
| let message = unwrapInboundIn(data) | ||
|
|
||
| self.logger.trace("SFTP IN: \(message.debugDescription)") |
There was a problem hiding this comment.
Is this logging line no longer needed in the renamed SFTPClientInboundHandler? (It seems like a copy and rename and this is the only line that is missing in that new file)
| @@ -126,6 +126,11 @@ public struct SFTPFileAttributes: CustomDebugStringConvertible { | |||
| // let extended_count: UInt32? | |||
|
|
|||
| public static let none = SFTPFileAttributes() | |||
| public static let all: SFTPFileAttributes = { | |||
There was a problem hiding this comment.
I'd prefer a more descriptive name since SFTPFileAttributes holds more than readwrite permissions so .all could be a little confusing in that case.
There was a problem hiding this comment.
We should really be implementing this for permissions: http://learn.leighcotnoir.com/wp-content/uploads/2016/08/POSIX-file-permissions.pdf as optionset . Then we don't need this .all
| @@ -126,6 +126,11 @@ public struct SFTPFileAttributes: CustomDebugStringConvertible { | |||
| // let extended_count: UInt32? | |||
There was a problem hiding this comment.
These two TODO's above are already public api?
| @@ -286,13 +320,26 @@ public enum SFTPMessage { | |||
| /// No response, directory gets created or an error is thrown. | |||
| case mkdir(MkDir) | |||
|
|
|||
| case stat(Stat) | |||
There was a problem hiding this comment.
Ideally some nice comments like the other enums :) (Since I don't immediately know what stat and lstat are or what attributes we're talking about here)
| ) | ||
| } | ||
| case .attributes(let command): | ||
| print(command) |
There was a problem hiding this comment.
same here for print statement
There was a problem hiding this comment.
this is a server-response type, so it cannot be received by a server
There was a problem hiding this comment.
This should throw an error
| } | ||
| } | ||
|
|
||
| final class CitadelServerDelegate { |
There was a problem hiding this comment.
Is this a new and non protocol version of the removed SSHServerDelegate ? Won't it need those same protocol conformances that used to have or is the similarity just coincidence?
| switch event { | ||
| case let event as SSHChannelRequestEvent.SubsystemRequest: | ||
| switch event.subsystem { | ||
| case "sftp": |
There was a problem hiding this comment.
Change to internal enum with supported protocols
| return XCTFail() | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Assertion, testdata.readablebytes == 0?
| import BigInt | ||
|
|
||
| enum SSHServerError: Error { |
No description provided.