Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging #91

Merged
merged 8 commits into from
May 10, 2022
Merged

Staging #91

merged 8 commits into from
May 10, 2022

Conversation

dougsillars
Copy link
Contributor

Updated subworkflow

added CICD docs

Fixed error in the HW codelab

@dougsillars dougsillars requested a review from v1r3n May 4, 2022 20:38

Our Conductor server is the [Orkes Playground](https://play.orkes.io) which has Access Control enabled (this is a feature of Orkes' Cloud, and not in the open source Conductor). If you are using the Open Source Conductor, you can skip this section.

In the PLayground, select ```Applications```, and add create a new application.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PLay vs Play

@@ -0,0 +1,142 @@
# Continuous Integration Continuous Deployment
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general documentation feels more relatable with "we and our" instead of "You and your"

```shell
$ wget "https://github.com/conductor-sdk/conductor-go/blob/main/examples/main/main.go"
```
Now, create simple worker implentation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling error

@dougsillars dougsillars merged commit e8c06bf into main May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants