Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal implementation of search #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

skissane
Copy link

This just does the bare minimum to add a search function (#10)

A lot of things are missing:

  • only exact match, no support for inexact matches (substring, glob, regex, etc)
  • should -d option be ignored when searching?
  • silently ignored with interactive mode; maybe it should display an error for unsupported combination of options?
  • exit status could communicate whether match is found or not (like grep)

But it is a start.

@skissane skissane changed the title Minimal implementation of search (#10) Minimal implementation of search Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants