Moved attachments and related tables from featureinfo to SelectedItem #2002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tried running this on a related tables configuration, looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1975 by adding the async createContentAsync() method on SelecedItem class. While doing that all code that creates the async content has been moved from featureinfo.js to getfeatureinfo.js while keeping the functionality intact.
For "standard" use of Origo, this PR will not change anything. The main benefit is that is is now possible to create SelectedItems containing async content and display them in InfoWindow from api or plugins, as the SelectedItem class is exposed in the global Origo object.