Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Origo master feature minor legend #1485

Merged
merged 21 commits into from
Apr 6, 2022

Conversation

Polleryd
Copy link
Contributor

@Polleryd Polleryd commented Mar 3, 2022

#1329

New config values for legend:
visibleLayersControl: boolean - Should visible layers control be active or not.
visibleLayersViewActive: boolean - Sets initial state minor legend.

The above settings, along with the setting "expanded", have also been appended to the share-map functionality.

@tonnyandersson
Copy link
Collaborator

Tested and noticed a few things:

  • Loading a map with one or more layers visible while using default settings (false) for visibleLayersControl results in a "broken" legend where the visibleLayersControl is active and visible on top of the regular legend.
    image

  • The legend toolbox is always expanded, even if there are no tools in it. Bug or feature?
    image

  • Icons should have the same fill color as the rest of the UI (#4a4a4a ).

  • New icons should ideally be placed in the section corresponding to the icon's Material Icons category. E.g., the ic_close_fullscreen_24px icon should be placed in the Action section and not in the Image section.
    image

  • Local changes to index.json should be removed before committing.

@asemoller
Copy link
Contributor

asemoller commented Mar 22, 2022

@tonnyandersson You're absolutely right, it doesn't look good something is really messed up when using the default index.json.
Apparently I haven't tested properly, I'm sorry about that 😟!

@tonnyandersson
Copy link
Collaborator

LGTM.

@tonnyandersson tonnyandersson linked an issue Apr 5, 2022 that may be closed by this pull request
@filleg filleg merged commit 1f3b0d2 into origo-map:master Apr 6, 2022
@asemoller asemoller deleted the origo-master-feature-minor-legend branch April 22, 2022 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor legend
4 participants