Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request processing should be forcefully stopped by indication to the storage #9344

Closed
andrii0lomakin opened this issue Jul 22, 2020 · 1 comment
Closed

Request processing should be forcefully stopped by indication to the storage #9344

andrii0lomakin opened this issue Jul 22, 2020 · 1 comment
Assignees
@andrii0lomakin
Labels
enhancement
Milestone
3.0.x

Comments

@andrii0lomakin
Copy link
Member

As for now, to stop the processing of the data in the long-running request we interrupt thread which leads to a side effect of the closing of the file channels if such ones are used at this moment. Instead of that, it is proposed to add flag into the storage which will allow throwing an exception during the call of the storage API from the particular thread.
@andrii0lomakin andrii0lomakin self-assigned this Jul 22, 2020
@andrii0lomakin andrii0lomakin added this to the 3.0.x milestone Jul 22, 2020
andrii0lomakin added a commit that referenced this issue Jul 22, 2020
@andrii0lomakin
Issue #9344 has been fixed.
23fe140
andrii0lomakin added a commit that referenced this issue Jul 22, 2020
@andrii0lomakin
Issue #9344, unconditional interruption was fixed.
c47a54f
andrii0lomakin added a commit that referenced this issue Jul 23, 2020
@andrii0lomakin
Issue #9344 - performance optimization.
d69a134
andrii0lomakin added a commit that referenced this issue Aug 3, 2020
@andrii0lomakin
Issue #9344 has been fixed.
743cde7
andrii0lomakin added a commit that referenced this issue Aug 3, 2020
@andrii0lomakin
Issue #9344 has been fixed.
5969c27
@andrii0lomakin
Copy link
Member Author

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrii0lomakin andrii0lomakin

Labels
enhancement
Milestone
3.0.x
Development

No branches or pull requests
1 participant
@andrii0lomakin