Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show source and target vertices when editing edges #435

Closed
santo-it opened this issue Jan 11, 2017 · 5 comments
Closed

Show source and target vertices when editing edges #435

santo-it opened this issue Jan 11, 2017 · 5 comments
Assignees
Milestone

Comments

@santo-it
Copy link

how to repeat

  • select * from e
  • click on an edge rid . edit edge window will be opened
  • in and out edges frames are enabled, and if you try to use them obviously you'll get an error "Cannot retrieve a vertex with the RID Export DB: change the text #25:1 because it is an edge"

please let's consider to disable these frames while editing an edge, if this operation is not allowed by design. this will help new users

perhaps an internal check to understand if we are editing a vertex or edge, and in case disable them in this second case?

thanks

@santo-it santo-it added the bug label Jan 11, 2017
@santo-it santo-it added this to the 2.2.x milestone Jan 11, 2017
@santo-it
Copy link
Author

@maggiolo00 hi, i'm tagging this with PBL1 as we fixed something related to this recently. makes sense we fix this as well for next release

thanks,

@santo-it
Copy link
Author

Actually, more than disabling the in and out edges frames, we may visualize source and target vertices frames, as suggested in orientechnologies/orientdb#1023. This would be more coherent with what we do when editing a vertex

So the frames would be:

"Source Vertex"
"Target Vertex"

Each frame would include the vertex rid (clickable --> edit vertex window)

@wolf4ood
Copy link
Member

@santo-it Fixed
In case of edge From/To Vertex are shown with the links to -> edit vertex

@santo-it santo-it changed the title Disable in and out edge frames when editing edges Show source and target vertices when editing edges Jan 16, 2017
@santo-it
Copy link
Author

Very well done @maggiolo00 . Much better now. Thanks

Just a question: have you tried the case of new edge. With edit edge I'm not having issues, but when I try to add an edge, and then add the out and in fields, the frames are updated showing what I type in those fields. When I save the record is saved, but when I try to visualize the two vertices, the edge is not shown. Just wondering if you handled the new edge creation as well.

I believe this is the last case of the all cases we recently reviewed (add vertex, edit vertex, edit edge)

Thanks,

@santo-it
Copy link
Author

Closing this. Will create a new issue for the "add edge" case. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants