Toolsreq 8242 appendix handling #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a test and code to automatically apply the "appendix" datatype to files beginning with "appx", e.g., "appxa", "appx_b", etc.
This refactor gets us data-typing for non-chapters (e.g., prefaces, but mostly appendixes) with subparts for free, and also cleans the code up. We move the logic to apply the chapter-wide data-types to its own function and allow the (new/old) process_chapter_soup function to take either a Path (single-file chapter) or a list (a chapter with subfiles). **NOTE**: We have to import `Union` from `typing` to support hinting for this; Python 3.10 gives us a much cleaner `|` operator, but Atlas currently is on 3.9. Update: parallelism in the initial if-check in process_chapter_soup
c84f870 to
5bd48b3
Compare
nadamsoreilly
approved these changes
Jan 3, 2023
delfanbaum
added a commit
that referenced
this pull request
Jan 9, 2025
delfanbaum
added a commit
that referenced
this pull request
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
data-type- ing for appendixes, as well as a refactor; see commit messages for further details. PR 1/4 on TOOLSREQ-8242.