Set size limit to 1024 on signet and testnet #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9727590 to
ffdd0a4
Compare
ffdd0a4 to
2a71929
Compare
hashbender
reviewed
Apr 16, 2024
| pub(crate) fn inscription_content_size_limit(self) -> Option<usize> { | ||
| match self { | ||
| Self::Mainnet | Self::Regtest => None, | ||
| Self::Testnet | Self::Signet => Some(1024), |
popcnt1
pushed a commit
to popcnt1/ord
that referenced
this pull request
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signet and testnet are both low-volume networks without a functioning fee market. Because of the potential for spam, we don't want to allow large inscriptions on those networks. Set the size limit to 1024 bytes for both signet and testnet, which is large enough that we'll exercise the content data chunking, but small enough that spam shouldn't be an issue. Regtest is a private test network, so spam is not an issue, and mainnet has a robust fee market, so large inscriptions will have to pay correspondingly high fees.