Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record commit start block count and timestamp #826

Merged
merged 6 commits into from
Nov 23, 2022
Merged

Conversation

casey
Copy link
Collaborator

@casey casey commented Nov 22, 2022

Store this information in the database for each commit, so we don't need to look at log files to get this information, we can just look at the index.

Also convert info command output to JSON, so we can represent data with nested fields.

@casey casey requested a review from raphjaph November 22, 2022 06:16
@casey casey force-pushed the show-commit-times branch from a39984a to c25c380 Compare November 22, 2022 19:52
@casey
Copy link
Collaborator Author

casey commented Nov 22, 2022

This commit adds a table and additional writes for every commit, so benchmarking before merging to make sure this doesn't introduce a performance regression.

@casey
Copy link
Collaborator Author

casey commented Nov 23, 2022

I benchmarked a full sync on ordinals.com overnight and it took 15h23m vs a baseline of 15h50m, so ~27 minutes less, which is probably just noise. It doesn't seem to have an impact on performance, so merging.

@casey casey merged commit 4942812 into master Nov 23, 2022
@casey casey deleted the show-commit-times branch November 23, 2022 20:18
popcnt1 pushed a commit to popcnt1/ord that referenced this pull request Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants