Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update miniscript dependency to 9.0.1 #1966

Merged
merged 4 commits into from
Apr 7, 2023

Conversation

soenkehahn
Copy link
Collaborator

Version 9.0.0 was yanked, see here:

I noticed this when running:
cargo install --offline --frozen --path .

Which gives a warning about using yanked versions from crates.io.

@casey
Copy link
Collaborator

casey commented Apr 7, 2023

Should we also change the Cargo.toml file? Since the lock file is sometimes ignored, maybe we should. Not sure what best practices are here.

@soenkehahn
Copy link
Collaborator Author

Should we also change the Cargo.toml file? Since the lock file is sometimes ignored, maybe we should. Not sure what best practices are here.

I think cargo would already prefer 9.0.1 over 9.0.0 without changing the Cargo.toml file, since 9.0.0 is yanked. I also think bumping the version in Cargo.toml doesn't hurt. If anything it prevents people from using a yanked version. So I changed it.

(Also not 100% sure about how this works and what best practices are.)

@casey
Copy link
Collaborator

casey commented Apr 7, 2023

Should we also change the Cargo.toml file? Since the lock file is sometimes ignored, maybe we should. Not sure what best practices are here.

I think cargo would already prefer 9.0.1 over 9.0.0 without changing the Cargo.toml file, since 9.0.0 is yanked. I also think bumping the version in Cargo.toml doesn't hurt. If anything it prevents people from using a yanked version. So I changed it.

(Also not 100% sure about how this works and what best practices are.)

Seems reasonable to me! Merging.

@casey casey merged commit 5591d5c into ordinals:master Apr 7, 2023
popcnt1 pushed a commit to popcnt1/ord that referenced this pull request Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants