Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Premine percentage formula should use the total supply #3630

Closed
habacrypto68 opened this issue Apr 20, 2024 · 5 comments · Fixed by #3748
Closed

Premine percentage formula should use the total supply #3630

habacrypto68 opened this issue Apr 20, 2024 · 5 comments · Fixed by #3748
Assignees

Comments

@habacrypto68
Copy link

Correct me if I am wrong, but this premine percentage formula that is being used in the portal is wrong:
((self.entry.premine as f64 / self.entry.supply() as f64) * 10000.0) as u128

The self.entry.supply() is actually calculating the circulating supply (premine + minted) instead of the total supply (premine + (cap * amount per mint))

@kusan-thana
Copy link

kusan-thana commented Apr 20, 2024

Yes, I guess a lot of people don't mint because they see premint at 100%.

I think the best would be to have both. Have the premine percentage with the current supply and the percentage with the fully diluted one.

@GiantDole
Copy link

Not sure about this... This would allow the attack vector of having a considerable cap but low duration to trick people.
Maybe having both percentages would be helpful for full transparency:
"Fully diluted percentage" and "Current percentage"

@cryptoni9n
Copy link
Collaborator

cryptoni9n commented Apr 20, 2024

edit: thinking about this more, I think the premine percentage formula should be PREMINE/MAX_SUPPLY. Additionally, I think the supply should be presented visually on the page as CURRENT_SUPPLY/MAX_SUPPLY or even "CURRENT_SUPPLY out of MAX_SUPPLY"

@raphjaph
Copy link
Collaborator

Yes, we should add more clarification to that

@HubertusVIE
Copy link

Yes, we should add more clarification to that

This is also related to #3677, as current total supply is what matters most, whereas the governance determined max total supply is more of an information item.

Consider that the max supply may be limited, like in Bitcredit Protocol or unlimited like in the RWA use cases mentioned by other supporters of #3677. This means that the second CURRENT/MAX percentage mentioned by @GiantDole and @cryptoni9n may be undetermined.

Also: Considering the BISQ scheme which we are emulating, the minting itself would be limited to the signature with governance rights.

@cryptoni9n cryptoni9n self-assigned this May 13, 2024
cryptoni9n added a commit to cryptoni9n/ord that referenced this issue May 13, 2024
presents options to fix ordinals#3630
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants