Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance of wallet inscriptions by iterating first over outputs instead of all inscriptions #2282

Closed
veryordinally opened this issue Jul 17, 2023 · 3 comments
Closed

Improve performance of wallet inscriptions by iterating first over outputs instead of all inscriptions #2282

veryordinally opened this issue Jul 17, 2023 · 3 comments

Comments

@veryordinally
Copy link
Collaborator

We currently iterate over all inscriptions (currently >16 million), and check for every single one if the satpoint is in our wallet. For wallets with typical number of outputs it would be much more efficient to iterate over outputs and check if it has an inscription.

Originally posted by @raphjaph in #2279 (comment)
@veryordinally veryordinally mentioned this issue Jul 17, 2023
Merged
veryordinally added a commit to veryordinally/ord that referenced this issue Jul 17, 2023
@veryordinally
Remove BACKLOG comment, now issue ordinals#2282
3efaeb6
@gmart7t2
Copy link
Contributor

This is how I fixed this issue: gmart7t2@8b10581

@gmart7t2
Copy link
Contributor

gmart7t2 commented Aug 1, 2023

I made a PR for my fix for this: #2310

@raphjaph
Copy link
Collaborator

Closed by #2310

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@veryordinally @raphjaph @gmart7t2