Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use change addresses for change #1801

Closed
gmart7t2 opened this issue Feb 20, 2023 · 0 comments · Fixed by #1847
Closed

Use change addresses for change #1801

gmart7t2 opened this issue Feb 20, 2023 · 0 comments · Fixed by #1847

Comments

@gmart7t2
Copy link
Contributor

gmart7t2 commented Feb 20, 2023 •
edited
Loading

When ord creates a wallet it uses internal = true for the receiving addresses and internal = false for change addresses. This is exactly backwards.

To see this, look at the change address in the commit tx. It is a receiving address not a change address. And look at the output of 'wallet receive'. It is a change address.

To fix this delete the ! before 'change' about 6 lines from the end of wallet.rs.
gmart7t2 added a commit to gmart7t2/ord that referenced this issue Feb 27, 2023
@gmart7t2
Fix ordinals#1801
0e2a7e6 
Mark change addresses as change addresses and receiving addresses as receiving addresses rather than the other way around.
@gmart7t2 gmart7t2 mentioned this issue Feb 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the ord wallet descriptors gmart7t2/ord
1 participant
@gmart7t2