[7.x] Prevent authentication route registrations when auth: false

Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
orchestral · Jan 7, 2025 · 01bffaf · 01bffaf
1 parent 11635f9
commit 01bffaf
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/src/Concerns/InteractsWithWorkbench.php b/src/Concerns/InteractsWithWorkbench.php
@@ -73,7 +73,7 @@ protected function getPackageProvidersUsingWorkbench($app): ?array
         $hasAuthentication = $config?->getWorkbenchAttributes()['auth'] ?? false;
         $providers = $config?->getExtraAttributes()['providers'] ?? [];
 
-        if ($hasAuthentication && class_exists('Orchestra\Workbench\AuthServiceProvider')) {
+        if ($hasAuthentication === true && class_exists('Orchestra\Workbench\AuthServiceProvider')) {
             $providers[] = 'Orchestra\Workbench\AuthServiceProvider';
         }
 

diff --git a/src/Workbench/Workbench.php b/src/Workbench/Workbench.php
@@ -86,10 +86,12 @@ public static function start(ApplicationContract $app, ConfigContract $config, a
      */
     public static function startWithProviders(ApplicationContract $app, ConfigContract $config): void
     {
-        static::start($app, $config, [
-            'Orchestra\Workbench\AuthServiceProvider',
+        $hasAuthentication = $config?->getWorkbenchAttributes()['auth'] ?? false;
+
+        static::start($app, $config, array_filter([
+            $hasAuthentication === true && class_exists('Orchestra\Workbench\AuthServiceProvider') ? 'Orchestra\Workbench\AuthServiceProvider' : null,
             'Orchestra\Workbench\WorkbenchServiceProvider',
-        ]);
+        ]));
     }
 
     /**