[Pool] Support Pool Deposit / Withdraw #35

ghost · 2021-08-26T08:44:37Z

Notes

Add functionality to deposit to and withdraw from a pool
Transactions didn't need to be split up

Tests

Tested deposit/withdraw on mainnet

Next Steps?

Create an /example directory and put code for interacting with the SDK
Utility function for calculating parameters for deposit and withdraw

odcheung

looks good with some minor comments!

src/model/orca/pool/orca-pool.ts

src/public/pools/types.ts

src/model/orca/pool/orca-pool.ts

odcheung

looks really good! minor comments on naming + owner object to support wallet use-case

src/model/orca/pool/orca-pool.ts

src/public/pools/types.ts

src/public/utils/web3/instructions/pool-instructions.ts

…nd-deposit

src/model/orca/pool/orca-pool.ts

odcheung

🚀

pool deposit/withdraw interface + deposit impl

79e817b

ghost requested a review from odcheung August 26, 2021 08:44

odcheung reviewed Aug 27, 2021

View reviewed changes

scuba added 4 commits August 31, 2021 22:50

pool withdraw impl + minor fixes

abdb647

move OrcaPoolToken to types.ts

ff431e1

fix: wrong pool token mint

8825c63

deposit/withdraw interface comments

b44337c

odcheung reviewed Sep 2, 2021

View reviewed changes

scuba added 3 commits September 1, 2021 22:38

edit comments and params for deposit/withdraw interface

f655caa

Merge remote-tracking branch 'origin/main' into scuba/pool-withdraw-a…

c6f257a

…nd-deposit

Rebase: support wallet signing for deposit/withdraw

bcccc06

ghost requested a review from odcheung September 2, 2021 17:37

odcheung reviewed Sep 6, 2021

View reviewed changes

src/model/orca/pool/orca-pool.ts Outdated Show resolved Hide resolved

src/model/orca/pool/orca-pool.ts Show resolved Hide resolved

minor name changes

24f46a9

ghost requested a review from odcheung September 6, 2021 23:47

odcheung approved these changes Sep 7, 2021

View reviewed changes

remove .DS_Store

420a46a

ghost merged commit 3163e72 into main Sep 8, 2021

ghost deleted the scuba/pool-withdraw-and-deposit branch September 8, 2021 04:39

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Pool] Support Pool Deposit / Withdraw #35

[Pool] Support Pool Deposit / Withdraw #35

ghost commented Aug 26, 2021 •

edited by ghost

Loading

odcheung left a comment

odcheung left a comment

odcheung left a comment

[Pool] Support Pool Deposit / Withdraw #35

[Pool] Support Pool Deposit / Withdraw #35

Conversation

ghost commented Aug 26, 2021 • edited by ghost Loading

Notes

Tests

Next Steps?

odcheung left a comment

Choose a reason for hiding this comment

odcheung left a comment

Choose a reason for hiding this comment

odcheung left a comment

Choose a reason for hiding this comment

ghost commented Aug 26, 2021 •

edited by ghost

Loading