Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use an enum to represent contract state #6

Open
mgcolburn opened this issue Apr 23, 2020 · 0 comments
Open

Use an enum to represent contract state #6

mgcolburn opened this issue Apr 23, 2020 · 0 comments

Comments

@mgcolburn
Copy link

Use an enum to represent contract state

Type: Code Quality
Target: DaiProxy.sol

Description

Rather than modifying an integer directly, use an enum to represent the different states of the contract. This will improve readability of the code and the ability to validate its expected behavior.
Jongsic added a commit that referenced this issue May 12, 2020
@Jongsic
#1 Added testing environment
259c43b 
#2 Added missing events
#3 bump up compiler version to 0.5.12(same with DAI)
#6 use enum to represent contract state
#7 Added methods to prevent "approve" race condition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mgcolburn