Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add multireader #199

Merged
merged 2 commits into from
Nov 17, 2020
Merged

add multireader #199

merged 2 commits into from
Nov 17, 2020

Conversation

deitch
Copy link
Contributor

@deitch deitch commented Nov 10, 2020

Provides option to wrap multiple stores to get a single content.Provider that can be used anywhere a Provider is needed.

@deitch deitch force-pushed the multireader branch 2 times, most recently from 7a5d7a4 to 5200b84 Compare November 10, 2020 20:05
jdolitsky
jdolitsky suggested changes Nov 12, 2020
View reviewed changes
Copy link
Contributor

@jdolitsky jdolitsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

possible to add unit test?

@jdolitsky jdolitsky changed the base branch from master to main November 12, 2020 03:30
@deitch
Copy link
Contributor Author

deitch commented Nov 12, 2020

Yeah, this one, I think, should be doable.

@deitch
add multireader
1043151 
Signed-off-by: Avi Deitcher <avi@deitcher.net>
@deitch
Copy link
Contributor Author

deitch commented Nov 12, 2020

Updated with a test

@jdolitsky jdolitsky merged commit 9555bb8 into oras-project:main Nov 17, 2020
@deitch deitch deleted the multireader branch November 17, 2020 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdolitsky jdolitsky jdolitsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deitch @jdolitsky