-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update --add should add plain descriptor #1513
Conversation
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1513 +/- ##
=======================================
Coverage 86.01% 86.02%
=======================================
Files 118 118
Lines 4225 4228 +3
=======================================
+ Hits 3634 3637 +3
+ Misses 353 352 -1
- Partials 238 239 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with minor suggestions
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
The code coverage is hard to increase since #1509 is still WIP. After #1509 is done, we can add a unified add function for both |
What this PR does / why we need it:
oras manifest index update --add
now adds the original manifest descriptor, and which may include the annotations. The command should add the plain descriptor.oras manifest index update --merge
still adds the original manifest descriptors. The annotations may be meaningful under merge scenarios.