feat(cmd/cp): add oci-layout-path flag #1507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
TerryHowe
reviewed
Sep 23, 2024
TerryHowe
requested changes
Oct 1, 2024
2ebab51 to
939d9bd
Compare
|
I updated the PR with the --from-oci-layout-path idea discussed on #1505. I'll update the documentation once we agree on this approach. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1507 +/- ##
==========================================
+ Coverage 83.84% 83.86% +0.02%
==========================================
Files 118 118
Lines 5156 5164 +8
==========================================
+ Hits 4323 4331 +8
Misses 592 592
Partials 241 241 ☔ View full report in Codecov by Sentry. |
shizhMSFT
requested changes
Oct 28, 2024
939d9bd to
91aeda1
Compare
|
It seems like it would be easy to add a e2e test for this. |
I added some tests. There is some duplication with the existing layout tests but I didn't find an easy way to avoid it. |
The oci-layout can't be used when the image reference contains a slash ( see issue 1505). This PR introduces a new oci-layout-path that explicitly receives the path of the oci layout fixing the parsing ambiguity. The usage of this flag is: oras cp --from-oci-layout-path <layout_path> <src> <dst> Signed-off-by: Mauricio Vásquez <mauriciov@microsoft.com>
Signed-off-by: Mauricio Vásquez <mauriciov@microsoft.com>
Signed-off-by: Mauricio Vásquez <mauriciov@microsoft.com>
5cca9a7 to
9718f09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The oci-layout can't be used when the image reference contains a slash ( see issue 1505). This PR introduces a new oci-layout-path that explicitly receives the path of the oci layout fixing the parsing ambiguity.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1505
Please check the following list: