Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: upgrade to Go 1.23.0 #1493

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Conversation

Wwwsylvia
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1492

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

@Wwwsylvia Wwwsylvia changed the title build: upgrade to go 1.23.0 build: upgrade to Go 1.23.0 Aug 30, 2024
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.54%. Comparing base (749d2ff) to head (ee54c02).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1493      +/-   ##
==========================================
- Coverage   85.59%   85.54%   -0.06%     
==========================================
  Files         113      113              
  Lines        3936     3936              
==========================================
- Hits         3369     3367       -2     
- Misses        340      342       +2     
  Partials      227      227              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@TerryHowe TerryHowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@TerryHowe
Copy link
Member

Hold this for oras-go?

@shizhMSFT
Copy link
Contributor

Hold this for oras-go?

Not necessary but good to do so.

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wwwsylvia
Copy link
Member Author

oras-go is now at Go 1.22.

Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
@shizhMSFT shizhMSFT merged commit 4c88cb8 into oras-project:main Sep 3, 2024
8 checks passed
@shizhMSFT shizhMSFT added this to the v1.3.0 milestone Sep 3, 2024
@Wwwsylvia Wwwsylvia deleted the bump_go branch September 3, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Go version to 1.23
3 participants