-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Create text copy handler #1441
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1441 +/- ##
==========================================
- Coverage 85.52% 85.48% -0.05%
==========================================
Files 109 109
Lines 3842 3851 +9
==========================================
+ Hits 3286 3292 +6
- Misses 333 335 +2
- Partials 223 224 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still need to add TTY implementation of status.CopyHandler. Not necessarily needed in this PR.
99520bf
to
11fd256
Compare
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
11fd256
to
faa4441
Compare
If this PR merges, it will be easier to create a tty handler and the successor PR is so bloated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What this PR does / why we need it:
This is a baby step to creating copy handlers for the cp command