Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Create text copy handler #1441

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

TerryHowe
Copy link
Member

What this PR does / why we need it:

This is a baby step to creating copy handlers for the cp command

Copy link

codecov bot commented Jul 7, 2024

Codecov Report

Attention: Patch coverage is 92.59259% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.48%. Comparing base (7a88524) to head (361025d).

Files Patch % Lines
cmd/oras/internal/display/status/text.go 88.88% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1441      +/-   ##
==========================================
- Coverage   85.52%   85.48%   -0.05%     
==========================================
  Files         109      109              
  Lines        3842     3851       +9     
==========================================
+ Hits         3286     3292       +6     
- Misses        333      335       +2     
- Partials      223      224       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cmd/oras/root/cp.go Outdated Show resolved Hide resolved
Copy link
Contributor

@qweeah qweeah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to add TTY implementation of status.CopyHandler. Not necessarily needed in this PR.

@TerryHowe TerryHowe force-pushed the text-copy-handler branch from 99520bf to 11fd256 Compare July 19, 2024 22:42
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
@TerryHowe TerryHowe force-pushed the text-copy-handler branch from 11fd256 to faa4441 Compare July 19, 2024 22:48
@TerryHowe
Copy link
Member Author

Still need to add TTY implementation of status.CopyHandler. Not necessarily needed in this PR.

If this PR merges, it will be easier to create a tty handler and the successor PR is so bloated.

Copy link
Contributor

@qweeah qweeah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah qweeah merged commit 5067a9a into oras-project:main Jul 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants