Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e test go work sum file #1412

Closed
wants to merge 1 commit into from

Conversation

TerryHowe
Copy link
Member

What this PR does / why we need it:

Add this file or ignore it?

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.09%. Comparing base (2aa005c) to head (e80fa63).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1412      +/-   ##
==========================================
- Coverage   85.14%   85.09%   -0.06%     
==========================================
  Files         107      107              
  Lines        3790     3790              
==========================================
- Hits         3227     3225       -2     
- Misses        336      338       +2     
  Partials      227      227              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Terry Howe <terrylhowe@gmail.com>
@TerryHowe TerryHowe force-pushed the add-e2e-go-work-sum branch from 7889a73 to e80fa63 Compare June 17, 2024 16:16
@qweeah
Copy link
Contributor

qweeah commented Jun 18, 2024

I would vote to ignore it, since the module sum of E2E test workspace should be tracked by test/e2e/go.sum

@sajayantony
Copy link
Contributor

Is there precedence in how other projects do this. I'm ok ignoring it but if this has some odd side effect of keeping or bringing unknown packages might move towards checkin this in.

@qweeah
Copy link
Contributor

qweeah commented Jun 19, 2024

Is there precedence in how other projects do this

I do see kubernetes checks in the work sum file. But the usage is different. k8s' workspace is created on the root module level but ORAS' workspace is created on e2e test module level. So if we check go work sum file in, we are doing it for ORAS E2E test module, not for ORAS CLI module.

Besides from testing packages (Gomega and Ginkgo), ORAS E2E test module should rely on same version of packages used by ORAS CLI module. So go work sum file won't be needed for cross-module package version control, and thus no need to check it in.

@qweeah
Copy link
Contributor

qweeah commented Jun 19, 2024

IMHO, the only advantage we don't ignore go work sum file is: we can clearly see a package version mismatch between CLI and E2E test module.

@TerryHowe TerryHowe closed this Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants