Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ux): give recommendation when empty creds found during basic auth #1235

Merged
merged 61 commits into from
Jan 19, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
61 commits
Select commit Hold shift + click to select a range
5dd63fd
chore(ux): show registry error and hint for dockehub
qweeah Dec 28, 2023
6994167
code clean
qweeah Dec 28, 2023
3c10c7d
support not found error
qweeah Dec 29, 2023
b0fa65a
Merge remote-tracking branch 'origin_src/main' into docker-error
qweeah Dec 29, 2023
0925a45
support `oras ls` and `oras pull`
qweeah Dec 29, 2023
11cb9cf
add e2e test
qweeah Dec 29, 2023
dbdaa59
code clean
qweeah Dec 29, 2023
c19a844
add error test for pull
qweeah Dec 29, 2023
354df3e
add unit test
qweeah Jan 2, 2024
20e23e3
support error prefix in cp and resolve
qweeah Jan 2, 2024
8594411
support push
qweeah Jan 2, 2024
fdb5d96
Merge remote-tracking branch 'origin_src/main' into docker-error
qweeah Jan 5, 2024
6d0a533
fix e2e
qweeah Jan 5, 2024
317556b
scrub debug info & handle empty response body
qweeah Jan 5, 2024
4076635
fix e2e
qweeah Jan 5, 2024
1d3fefa
fix e2e
qweeah Jan 5, 2024
1c01b0a
fix e2e
qweeah Jan 7, 2024
937d80c
fix e2e
qweeah Jan 7, 2024
d905d0f
Merge remote-tracking branch 'origin_src/main' into docker-error
qweeah Jan 8, 2024
ae3dd7b
support all commands and add e2e
qweeah Jan 8, 2024
70ac3a0
bug fix
qweeah Jan 8, 2024
92588f5
improve readability
qweeah Jan 8, 2024
668152d
resolve empty resp body
qweeah Jan 8, 2024
fa3adf1
resolve e2e
qweeah Jan 8, 2024
cc42b04
code clean
qweeah Jan 8, 2024
666c518
fix e2e
qweeah Jan 8, 2024
028beb0
fix e2e
qweeah Jan 8, 2024
537b325
remove deps on credential-go
qweeah Jan 8, 2024
63a6cba
chore(ux): give recommendation for empty basic auth creds
qweeah Jan 9, 2024
3078596
bump oras-go
qweeah Jan 9, 2024
716e62a
resolve comment
qweeah Jan 9, 2024
4503268
code clean
qweeah Jan 9, 2024
9d299a9
bug fix
qweeah Jan 9, 2024
3607c16
resolve comments
qweeah Jan 9, 2024
a9664b3
resolve comments
qweeah Jan 11, 2024
0131f02
bug fix
qweeah Jan 11, 2024
e47e0d3
add coverage
qweeah Jan 11, 2024
0494f77
add unit test
qweeah Jan 11, 2024
19b7ec1
fix e2e
qweeah Jan 11, 2024
e530def
fix full reference match and add UT
qweeah Jan 11, 2024
ff6a9ba
cover more
qweeah Jan 11, 2024
b12d29e
code clean
qweeah Jan 11, 2024
ce2582a
add TODO
qweeah Jan 11, 2024
7c99330
add coverage
qweeah Jan 11, 2024
162a9dc
increase coverage
qweeah Jan 11, 2024
01032af
Merge branch 'docker-error' into client-auth-error
qweeah Jan 11, 2024
f4d4e99
support basic credential not found
qweeah Jan 11, 2024
55d758d
add recommendation
qweeah Jan 12, 2024
2daac4c
code clean
qweeah Jan 12, 2024
b6c3762
update to latest implementation in oras-go
qweeah Jan 12, 2024
8b9abda
Merge remote-tracking branch 'origin_src/main' into client-auth-error
qweeah Jan 16, 2024
deb520e
bump oras-go
qweeah Jan 18, 2024
6196cf3
support all commands with e2e tests
qweeah Jan 18, 2024
e6e6518
remove focus
qweeah Jan 18, 2024
25faee3
fix e2e
qweeah Jan 18, 2024
3edc055
bug fix
qweeah Jan 18, 2024
9f1377c
support error array
qweeah Jan 18, 2024
fed3c47
doc clean
qweeah Jan 18, 2024
1958e0b
code clean
qweeah Jan 18, 2024
b9eef0d
resolve comment
qweeah Jan 19, 2024
76d7e80
Merge remote-tracking branch 'origin_src/main' into client-auth-error
qweeah Jan 19, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
code clean
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
  • Loading branch information
qweeah committed Jan 8, 2024
commit cc42b046ba3be9b55f77b0a907f1361596776a15
1 change: 0 additions & 1 deletion cmd/oras/internal/errors/errors.go
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@ func Command(cmd *cobra.Command, handler Handler) *cobra.Command {
}

// GetInner gets the inner error from the error response.
// nil is returned if no valid inner error is found.
func GetInner(err error, errResp *errcode.ErrorResponse) error {
inner := errResp.Errors
if len(inner) == 0 {
Expand Down
3 changes: 0 additions & 3 deletions cmd/oras/internal/option/target.go
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,6 @@ func (opts *Target) EnsureReferenceNotEmpty() error {

// Handle handles error during cmd execution.
func (opts *Target) Handle(err error, cmd *cobra.Command) (oerrors.Processor, error) {
// handle registry error
if opts.IsOCILayout {
return nil, err
}
Expand All @@ -268,9 +267,7 @@ func (opts *Target) Process(err error, callPath string) *oerrors.Error {

var errResp *errcode.ErrorResponse
if errors.As(err, &errResp) {
// remove HTTP related info
ret.Err = oerrors.GetInner(err, errResp)

ref, parseErr := registry.ParseReference(opts.RawReference)
if parseErr != nil {
// this should not happen
Expand Down
Loading