-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add resolve command #1187
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1187 +/- ##
==========================================
+ Coverage 80.09% 80.34% +0.25%
==========================================
Files 65 66 +1
Lines 3572 3618 +46
==========================================
+ Hits 2861 2907 +46
Misses 497 497
Partials 214 214 ☔ View full report in Codecov by Sentry. |
Thanks @sajayantony . Could you associate the original issue #907 with this PR? |
…tput Signed-off-by: amands98 <amandeepsm.in@gmail.com>
Co-authored-by: Billy Zha <qweeah@gmail.com> Signed-off-by: Aman <136564604+amands98@users.noreply.github.com>
Signed-off-by: Sajay Antony <sajaya@microsoft.com>
Signed-off-by: Sajay Antony <sajaya@microsoft.com>
Co-authored-by: Feynman Zhou <feynman@kubesphere.io> Co-authored-by: Billy Zha <qweeah@gmail.com> Signed-off-by: Sajay Antony <sajaya@microsoft.com>
Closes #907 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: amands98 <amandeepsm.in@gmail.com> Co-authored-by: Billy Zha <qweeah@gmail.com> Co-authored-by: Feynman Zhou <feynman@kubesphere.io> Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
What this PR does / why we need it:
This is an update with a test and flags based of PR from @amands98.
@amands98 if you would like to combine these commits I'm more than happy to send a PR to your branch.
Fixes #907.