Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: support OCI artifact manifest with descriptor migration #334

Merged
merged 2 commits into from
Sep 28, 2022
Merged

feat!: support OCI artifact manifest with descriptor migration #334

merged 2 commits into from
Sep 28, 2022

Conversation

Wwwsylvia
Copy link
Member

@Wwwsylvia Wwwsylvia commented Sep 28, 2022 •
edited
Loading

The work of migrating ORAS Artifact to OCI Artifact is partially done on the oci-playground/oras-go main branch.
We will continue the migration work on oras-project/oras-go main branch going forward.

Resolves #307
Resolves #308
BREAKING CHANGE: change the parameter type of Referrers
Signed-off-by: Lixia (Sylvia) Lei lixlei@microsoft.com

Wwwsylvia and others added 2 commits September 23, 2022 14:51
@Wwwsylvia
refactor!: Migrate artifactspec.Descriptor to ocispec.Descriptor (#1
c739292 
)

Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
@Wwwsylvia
feat: Support OCI Artifact Manifest (#2)
22db027 
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
@codecov-commenter
Copy link

Codecov Report

Merging #334 (22db027) into main (3f9653f) will decrease coverage by 0.27%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##             main     #334      +/-   ##
==========================================
- Coverage   72.46%   72.18%   -0.28%     
==========================================
  Files          38       38              
  Lines        3621     3635      +14     
==========================================
  Hits         2624     2624              
- Misses        738      752      +14     
  Partials      259      259
Impacted Files Coverage Δ
content/graph.go 0.00% <0.00%> (ø)
registry/remote/manifest.go 92.85% <ø> (ø)
registry/repository.go 0.00% <ø> (ø)
extendedcopy.go 68.96% <100.00%> (ø)
registry/remote/repository.go 66.66% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

shizhMSFT
shizhMSFT approved these changes Sep 28, 2022
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wwwsylvia Wwwsylvia changed the title feat!: Partially support OCI Artifact feat!: support OCI artifact manifest and descriptor Sep 28, 2022
@Wwwsylvia Wwwsylvia changed the title feat!: support OCI artifact manifest and descriptor feat!: support OCI artifact manifest with descriptor migration Sep 28, 2022
@Wwwsylvia Wwwsylvia merged commit c1f42a4 into oras-project:main Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shizhMSFT shizhMSFT shizhMSFT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for OCI Artifact manifest Migrate artifactspec.Descriptor to ocispec.Descriptor
3 participants
@Wwwsylvia @codecov-commenter @shizhMSFT