feat: add read and verify utility method #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #324 +/- ##
==========================================
+ Coverage 71.79% 72.42% +0.62%
==========================================
Files 38 38
Lines 3584 3615 +31
==========================================
+ Hits 2573 2618 +45
+ Misses 754 738 -16
- Partials 257 259 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
wangxiaoxuan273
commented
Sep 19, 2022
|
Should I add unit tests to |
shizhMSFT
requested changes
Sep 20, 2022
Wwwsylvia
reviewed
Sep 20, 2022
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
Added some unit tests to |
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
shizhMSFT
reviewed
Sep 20, 2022
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
shizhMSFT
reviewed
Sep 20, 2022
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
Wwwsylvia
reviewed
Sep 20, 2022
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
shizhMSFT
reviewed
Sep 21, 2022
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added VerifyReader struct that performs verification against the digest and size when reading content. Changed
CopyBufferto useVerifyReader.resolves #306
Signed-off-by: wangxiaoxuan273 wangxiaoxuan119@gmail.com