Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Referrers API support for OCI Layout #392

Closed
shizhMSFT opened this issue Dec 23, 2022 · 3 comments · Fixed by #659
Closed

Referrers API support for OCI Layout #392

shizhMSFT opened this issue Dec 23, 2022 · 3 comments · Fixed by #659
Assignees
@wangxiaoxuan273
Labels
enhancement New feature or request experimental Issues or pull requests depending on WIP specs
Milestone
v2.4.0

Comments

@shizhMSFT
Copy link
Contributor

The OCI layout can be viewed as a simplified local repository, which should also support the equivalence of Referrers API.

Proposal: Let content/oci.Store and content/oci.ReadOnlyStore implement registry.ReferrerFinder.
@shizhMSFT shizhMSFT added this to the future milestone Dec 23, 2022
@shizhMSFT shizhMSFT modified the milestones: future, v2.0.0 Dec 23, 2022
@shizhMSFT shizhMSFT added the enhancement New feature or request label Dec 23, 2022
@shizhMSFT shizhMSFT modified the milestones: v2.0.0, future Dec 23, 2022
@shizhMSFT
Copy link
Contributor Author

In terms of functionality, Referrers() is a subset of Predecessors(). Therefore, we can use Predecessors() to implement Referrers().

@shizhMSFT
Copy link
Contributor Author

There is a generic implementation in oras: https://github.com/oras-project/oras/blob/660d167c8434b19da455828e1f30ee7f3864638c/internal/graph/graph.go#L65

We can consider move and improve the above implementation to oras-go.

@shizhMSFT shizhMSFT modified the milestones: future, v2.1.0 Mar 22, 2023
@shizhMSFT shizhMSFT added the experimental Issues or pull requests depending on WIP specs label Mar 22, 2023
@shizhMSFT shizhMSFT mentioned this issue Mar 22, 2023
Closed
@shizhMSFT shizhMSFT modified the milestones: v2.1.0, v2.2.0 May 4, 2023
@Wwwsylvia Wwwsylvia modified the milestones: v2.2.0, v2.3.0 May 24, 2023
@yizha1 yizha1 modified the milestones: v2.3.0, v2.4.0 Aug 1, 2023
@yizha1 yizha1 modified the milestones: v2.4.0, v2.5.0 Nov 22, 2023
@wangxiaoxuan273
Copy link
Contributor

I'd like to work on this.

@nathan-joslin nathan-joslin mentioned this issue Dec 13, 2023
Closed
@wangxiaoxuan273 wangxiaoxuan273 mentioned this issue Dec 15, 2023
Merged
Wwwsylvia pushed a commit that referenced this issue Dec 27, 2023
@wangxiaoxuan273
feat: Referrers support for content.ReadOnlyGraphStorage (#659)
1d9ad6c 
This PR provides `Referrers` support for the
`content.ReadOnlyGraphStorage` interface, which includes `oci.Store`.

Resolves #392
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
@github-project-automation github-project-automation bot moved this from Todo to Done in ORAS Project Board-2023 Dec 27, 2023
@FeynmanZhou FeynmanZhou modified the milestones: v2.5.0, v2.4.0 Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wangxiaoxuan273 wangxiaoxuan273

Labels
enhancement New feature or request experimental Issues or pull requests depending on WIP specs
Projects
ORAS Project Board-2023
Status: Done
ORAS-Planning
Status: No status
Milestone
v2.4.0
Development

Successfully merging a pull request may close this issue.

feat: Referrers support for content.ReadOnlyGraphStorage wangxiaoxuan273/oras-go
5 participants
@Wwwsylvia @shizhMSFT @FeynmanZhou @wangxiaoxuan273 @yizha1