feat: implement referrers deletion #54
Conversation
Codecov Report
@@ Coverage Diff @@
## main #54 +/- ##
==========================================
- Coverage 56.28% 56.27% -0.01%
==========================================
Files 108 108
Lines 11213 11239 +26
==========================================
+ Hits 6311 6325 +14
- Misses 4194 4202 +8
- Partials 708 712 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
registry/storage/manifeststore.go
Outdated
| } | ||
|
|
||
| // Ensure the blob is available for deletion | ||
| _, err := ms.blobStore.blobAccessController.Stat(ctx, dgst) |
There was a problem hiding this comment.
We can do ms.blobStore.Stat() to get the descriptor. If the media type is not MediaTypeArtifactManifest or MediaTypeImageManifest, we can do ms.blobStore.Delete(ctx, dgst) directly.
There was a problem hiding this comment.
The descriptor we get from ms.blobStore.Stat() has an incorrect media type.
| if err != nil { | ||
| return fmt.Errorf("failed to generate referrers link path for %v", dgst) | ||
| } | ||
| if err = ms.repository.driver.Delete(ctx, referrersLinkPath); err != nil { |
There was a problem hiding this comment.
What if subject is specified but does not exist (as mentioned in #52)?
There was a problem hiding this comment.
If the subject does not exist in the repository, the referrers feature just works as usual, which is technically conformant to the distribution spec.
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
Part 2 of and Resolves #37
Basic Test result using
oras:delete a referrer of an artifact manifest
delete a referrer of an image manifest
Signed-off-by: wangxiaoxuan273 wangxiaoxuan119@gmail.com