feat: support referrers for oci image manifests #43
Conversation
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
|
Test result: Prettified result: |
registry/handlers/referrers.go
Outdated
| func getArtifactReferrers(ctx context.Context, | ||
| blobStatter distribution.BlobStatter, | ||
| referrerDigest digest.Digest, | ||
| man distribution.Manifest, | ||
| referrers *[]v1.Descriptor, | ||
| artifactType string) error { |
There was a problem hiding this comment.
Instead of the code pattern
func doSomething(result *[]any)Try golang-style
func doSomething(result []any) []anyThere was a problem hiding this comment.
In fact, you don't even need to pass the referrers. All you want to return is a referrer descriptor.
Think about
func generateReferrerFromArtifact(ctx context.Context, blobStatter distribution.BlobStatter, referrerDigest digest.Digest, man *ociartifact.DeserializedManifest, artifactType string) (v1.Descriptor, error)You could apply the same thing to getImageReferrers.
There was a problem hiding this comment.
Good point. Changed accordingly.
registry/handlers/referrers.go
Outdated
| func getArtifactReferrers(ctx context.Context, | ||
| blobStatter distribution.BlobStatter, | ||
| referrerDigest digest.Digest, | ||
| man distribution.Manifest, |
There was a problem hiding this comment.
Why not?
| man distribution.Manifest, | |
| man *ociartifact.DeserializedManifest, |
registry/handlers/referrers.go
Outdated
| case *ociartifact.DeserializedManifest: | ||
| return getArtifactReferrers(ctx, blobStatter, referrerDigest, man, &referrers, artifactType) | ||
| default: | ||
| return fmt.Errorf("referrers not supported for this manifest type") |
There was a problem hiding this comment.
Should it return nil to keep the previous behavior?
registry/handlers/referrers.go
Outdated
| return nil | ||
| } | ||
|
|
||
| func getImageReferrers(ctx context.Context, |
There was a problem hiding this comment.
In Image Manifest, the media type of the config is used as the artifact type.
There was a problem hiding this comment.
Added filtering with config media type.
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #43 +/- ##
==========================================
- Coverage 56.48% 56.31% -0.18%
==========================================
Files 108 108
Lines 11176 11211 +35
==========================================
Hits 6313 6313
- Misses 4153 4188 +35
Partials 710 710
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Resolves #39
Part 9 of #21
Signed-off-by: wangxiaoxuan273 wangxiaoxuan119@gmail.com