-
Notifications
You must be signed in to change notification settings - Fork 30
Conversation
Signed-off-by: Steve Lasker <stevenlasker@hotmail.com>
92f4390
to
ab408dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I would like to see if @justincormack or @michaelb990 had any input on this.
I don't really understand the use case "If the mediaType is know to be a manifest, supported by the registry, it would parse the manifest and possibly track additional lifecycle management links." in the issue - can someone elaborate? |
The use case is: Can the ORAS artifact manifest be used for OCI Index scenarios? In theory, the blobs collection could contain the helm chart content, and references to the images: {
"artifactType": "application/vnd.cncf.helm.vFuture+json",
"blobs": [
{
"comment": "helm chart config",
"mediaType": "application/vnd.cncf.helm.config.v1+json",
"digest": "sha256:e752324f6804d5d0b2c098f84507d095a8fd0031cf06cdb3c7ad1625dcd1b399",
"size": 7097
},
{
"comment": "helm chart",
"mediaType": "application/vnd.cncf.helm.chart.content.v1.tar+gzip",
"digest": "sha256:83c5cfdaa5385ea6fc4d31e724fd4dc5d74de847a7bdd968555b8f2c558dac0e",
"size": 25851449
},
{
"comment": "helm chart provenance",
"mediaType": "application/vnd.cncf.helm.chart.provenance.v1.prov",
"digest": "sha256:7445693bd43e8246a8c166233392b33143f7f5e396c480f74538e5738fb6bd6e",
"size": 226
},
{
"comment": "wordpress-image",
"mediaType": "application/vnd.oci.image.manifest.v1+json",
"digest": "sha256:8145693bd43e8246a8c166233392b33143f7f5e396c480f74538e5738fb6bd18",
"size": 1023
},
{
"comment": "mysql",
"mediaType": "application/vnd.oci.image.manifest.v1+json",
"digest": "sha256:3785693bd43e8246a8c166233392b33143f7f5e396c480f74538e5738fb6g27",
"size": 3014
}
]
} It could also just replace the current OCI Index and just be a multi-arch index of content in the same repository. I've minimized the amount of content in the parent issue: #73, as we're really just scoping a name change for now.
As to how the logic might work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Name change is fine. Change in scope is more complicated and needs review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto what @justincormack said.
Merging the change. |
Fixes #73
There is no scope change with this PR. This is a property change only, enabling the future possibility for
[descriptors]
to reference other manifests, similar to the index.