Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go directive to 1.21 instead of 1.21.0 #14

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

pjarmalavicius
Copy link
Contributor

Having 1.21.0 and using newer version, e.g. 1.21.4, go mod tidy adds toolchain go1.21.4 to my project. However, some people working on a project might be using 1.21.3 or 1.21.2 and so on. So let's not be so strict and set it to 1.21 without patch

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (567e4ff) 100.00% compared to head (03d8d85) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #14   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          129       129           
=========================================
  Hits           129       129           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orandin orandin merged commit 244952e into orandin:master Feb 21, 2024
3 checks passed
@orandin
Copy link
Owner

orandin commented Feb 21, 2024

Thank @pjarmalavicius for your contribution

@pjarmalavicius
Copy link
Contributor Author

@orandin can you please bump the release version?

@orandin
Copy link
Owner

orandin commented Feb 24, 2024

done 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants