The strtol() method with a base of 0 treats leading zeroes as an octa…

…l number, which leads to corruption of numbers like 1e-08 and 1e-09 (oracle/python-cx_Oracle#300).
oracle · May 3, 2019 · e53746b · e53746b
1 parent c059aa8
commit e53746b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/dpiUtils.c b/src/dpiUtils.c
@@ -251,7 +251,7 @@ int dpiUtils__parseNumberString(const char *value, uint32_t valueLength,
             return dpiError__set(error, "no digits in exponent",
                     DPI_ERR_INVALID_NUMBER);
         exponentDigits[numExponentDigits] = '\0';
-        exponent = (int16_t) strtol(exponentDigits, NULL, 0);
+        exponent = (int16_t) strtol(exponentDigits, NULL, 10);
         if (exponentIsNegative)
             exponent = -exponent;
         *decimalPointIndex += exponent;

diff --git a/test/TestNumbers.c b/test/TestNumbers.c
@@ -278,10 +278,10 @@ int dpiTest_205_bindNumberAsString(dpiTestCase *testCase,
     const char *outValues[] = { "400000000", "1521000000000000",
             "5478000000000000000", "100000000000",
             "-1234567890123456789012345678901234567.8", "0", "0", "0", "0",
-            NULL };
+            "0.00000001", "0.000000001", NULL };
     const char *inValues[] = { "4E+8", "1.521E+15", "5.478E+18", "1E+11",
             "-1234567890123456789012345678901234567.8", "0", "-0", "0.0",
-            "-0.0", NULL };
+            "-0.0", "1e-08", "1e-09", NULL };
     const char *sql = "select :1 from dual";
     dpiData *inputVarData, *resultVarData;
     dpiVar *inputVar, *resultVar;