refactor(SonarCloud): implement code recommendations

ocd/packages/core/src/OcdUtils.ts

@@ -58,8 +58,8 @@ export namespace OcdUtils {
     export function isCondition(leftHandSide: string | number | boolean | Array<any> | Function | undefined, operator: string | undefined, rightHandSide: string | number | boolean | Array<any> | Function | undefined): boolean {
         let isTrue = false
         // console.debug('OcdUtils: isConditional', leftHandSide, operator, rightHandSide)
-        if (operator === 'eq') isTrue = (leftHandSide === rightHandSide)
-        else if (operator === 'ne') isTrue = (leftHandSide !== rightHandSide)
+        if (operator === 'eq')      isTrue = (leftHandSide !== undefined && rightHandSide !== undefined && leftHandSide === rightHandSide)
+        else if (operator === 'ne') isTrue = (leftHandSide !== undefined && rightHandSide !== undefined && leftHandSide !== rightHandSide)
         else if (operator === 'lt') isTrue = (leftHandSide !== undefined && rightHandSide !== undefined && leftHandSide < rightHandSide)
         else if (operator === 'gt') isTrue = (leftHandSide !== undefined && rightHandSide !== undefined && leftHandSide > rightHandSide)
         else if (operator === 'le') isTrue = (leftHandSide !== undefined && rightHandSide !== undefined && leftHandSide <= rightHandSide)

ocd/packages/model/src/validator/OcdResourceValidator.ts

@@ -30,8 +30,9 @@ export namespace OcdResourceValidator {
         // If not conditional then we will always display
         if (!conditional) return true
         // Check condition
-        const element = condition.element ? condition.element.indexOf('_') ? OcdUtils.toCamelCase(condition.element)  : condition.element : ''
-        const display = OcdUtils.isCondition(resource[element], condition.operator, condition.value)
+        const element = condition.element?.indexOf('_') ? OcdUtils.toCamelCase(condition.element)  : condition.element
+        const leftValue = element ? resource[element] : ''
+        const display = OcdUtils.isCondition(leftValue, condition.operator, condition.value)
         return display
     }
     export function noDefaultValidation(displayName: string, key: string, value: string | boolean | number, title: string, cssClass: string, resources: OcdResources, message: string | undefined = undefined): OcdValidationResult {

okitweb/static/okit/view/js/okit_view.js

@@ -56,10 +56,10 @@ class OkitJsonView {
     drop(source, target) {
         let newFunction = 'new' + source.name;
         let getFunction = 'get' + target.type.split(' ').join('');
+        console.debug('OkitJsonView: New:', newFunction,'Get:', getFunction)
     }
 
-    init() {
-    }
+    init() {return}
 
     clear() {
         for (const [key, value] of Object.entries(this)) {
@@ -166,7 +166,7 @@ class OkitArtefactView {
     static get fo_x_tranlation() {return this.icon_width + 5;}
     static get fo_y_tranlation() {return 0;}
 
-    constructor(artefact=null, json_view) {
+    constructor(artefact, json_view) {
         this.artefact = artefact;
         // this.view = json_view
         // this.artefact = new Proxy(artefact, model_proxy_handler);
@@ -338,6 +338,7 @@ class OkitArtefactView {
             id: this.icon_definition_id,
             transform: this.icon_transform
         }
+        return definition
     }
     getForeignObjectDefinition() {
         const definition = {