Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sprint 9 #106

Merged
merged 54 commits into from
Sep 16, 2020
Merged
Changes from 1 commit
Commits
Show all changes
54 commits
Select commit Hold shift + click to select a range
6a8b4bc
Move Instance Pool back into palette
toxophilist Aug 27, 2020
6a52baf
Add initial Framework to import HCL (Terraform) Json
toxophilist Aug 28, 2020
03a7dff
Comment out Import menu item until we are ready for release.
toxophilist Aug 28, 2020
24f881a
Merge pull request #93 from oracle/toxophilist/sprint-9/OKIT-104
toxophilist Aug 28, 2020
3593386
Add loop through a number of character sets during decode of user-data
toxophilist Sep 4, 2020
d8544ab
Query DRG Attachments when querying DRG
toxophilist Sep 4, 2020
47db26e
Add toggle to include sub compartments in query and default to false.
toxophilist Sep 4, 2020
c325ff6
Add Save Regional to specifically save the results of a query and mod…
toxophilist Sep 4, 2020
ad8aebc
Merge pull request #95 from oracle/toxophilist/sprint-9/OKIT-104
toxophilist Sep 4, 2020
8b48fdb
Remove specific linux version
toxophilist Sep 4, 2020
f1a49f0
Change save as template to save to a mounted directory
toxophilist Sep 4, 2020
db38d6f
Instance Pool Query Functionality
toxophilist Sep 7, 2020
72d2452
Convert Load Balancer Backends to Multi Checkbox select
toxophilist Sep 7, 2020
4632b9d
Convert Instance NSGs to Multi Checkbox select
toxophilist Sep 8, 2020
ef71acf
Clean code
toxophilist Sep 8, 2020
bca7b7b
Convert Security List multi select to checkboxes
toxophilist Sep 8, 2020
7b89216
Clean code
toxophilist Sep 8, 2020
f9191d2
Convert NSGs multi select to checkboxes
toxophilist Sep 8, 2020
89acd9d
Clean Code
toxophilist Sep 8, 2020
2201a2a
Modify NSGs and Fault Domain multi selects to multiple checkboxes
toxophilist Sep 8, 2020
590d4fa
Convert load network security groups to a common method and convert N…
toxophilist Sep 8, 2020
2e6aeec
Merge pull request #97 from oracle/toxophilist/sprint-9/OKIT-104
toxophilist Sep 9, 2020
970c6c4
Convert block volumes multi select to checkboxes
toxophilist Sep 9, 2020
8857a20
Update version number
toxophilist Sep 10, 2020
4c2df82
Add followlinks to the os walk for templates
toxophilist Sep 10, 2020
b834f6b
Merge branch 'sprint-9' into toxophilist/sprint-9/OKIT-104
toxophilist Sep 10, 2020
1a9accd
Merge pull request #99 from oracle/toxophilist/sprint-9/OKIT-104
toxophilist Sep 10, 2020
2759b84
Update README
toxophilist Sep 10, 2020
6311c36
Force Database System CPU Count to integer for test Issue: #98
toxophilist Sep 10, 2020
9a303e6
Force Database System CPU Count to integer for test Issue: #98
toxophilist Sep 10, 2020
1c12a87
Merge pull request #100 from oracle/toxophilist/sprint-9/OKIT-104
toxophilist Sep 10, 2020
dba177e
Check Parent Exists before getting child offset and delete Network Se…
toxophilist Sep 11, 2020
99e9069
Merge pull request #101 from oracle/toxophilist/sprint-9/OKIT-104
toxophilist Sep 11, 2020
72c4130
Check Parent Exists before getting child offset and delete Network Se…
toxophilist Sep 11, 2020
ac38d0b
change console.group calls to console.log
toxophilist Sep 14, 2020
14d4c79
Add Title and Description to the BUI
toxophilist Sep 14, 2020
54d333d
Merge pull request #102 from oracle/toxophilist/sprint-9/OKIT-104
toxophilist Sep 14, 2020
121c63e
Update changelog
toxophilist Sep 14, 2020
bea321b
Resolve display issue for DRG when it is not connected to a VCN
toxophilist Sep 15, 2020
8ce5dfa
Merge pull request #103 from oracle/toxophilist/sprint-9/OKIT-104
toxophilist Sep 15, 2020
af00a80
Update Changelog
toxophilist Sep 15, 2020
37bef2e
Fix typo in vagrant instructions
toxophilist Sep 15, 2020
0ca1fd5
Fix typo in vagrant instructions
toxophilist Sep 15, 2020
614f56d
Fix typo in error properties name
toxophilist Sep 15, 2020
d85a316
Merge pull request #104 from oracle/toxophilist/sprint-9/OKIT-104
toxophilist Sep 15, 2020
fcea165
Hide Instance Pool Palette Icon
toxophilist Sep 15, 2020
234013e
Merge pull request #105 from oracle/toxophilist/sprint-9/OKIT-104
toxophilist Sep 15, 2020
441c391
Update Installation guide
toxophilist Sep 16, 2020
29fafb6
Merge remote-tracking branch 'origin/sprint-9' into sprint-9
toxophilist Sep 16, 2020
fde2280
Update Installation guide
toxophilist Sep 16, 2020
a5dc1bd
Update Installation guide
toxophilist Sep 16, 2020
86117b1
Update Installation guide
toxophilist Sep 16, 2020
5393bf0
Update Installation guide
toxophilist Sep 16, 2020
e882927
Update Readme
toxophilist Sep 16, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Resolve display issue for DRG when it is not connected to a VCN
  • Loading branch information
toxophilist committed Sep 15, 2020
commit bea321b7517871a0237c20b460f3ffc84378c34d
Original file line number Diff line number Diff line change
@@ -12,10 +12,11 @@ class DynamicRoutingGatewayView extends OkitDesignerArtefactView {
super(artefact, json_view);
}

get parent_id() {return this.artefact.vcn_id;}
get parent_id() {return this.artefact.vcn_id && this.artefact.vcn_id !== '' ? this.artefact.vcn_id : this.artefact.compartment_id;}
get parent() {return this.artefact.vcn_id && this.artefact.vcn_id !== '' ? this.getJsonView().getVirtualCloudNetwork(this.parent_id) : this.getJsonView().getCompartment(this.parent_id);}

getParent() {
return this.getJsonView().getVirtualCloudNetwork(this.parent_id);
return this.parent;
}

getParentId() {
2 changes: 1 addition & 1 deletion sonar-project.properties
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
sonar.projectKey=a-team:oci-designer-toolkit
sonar.projectKey=oci-designer-toolkit
sonar.projectName=OCI Designer Toolkit
sonar.projectVersion=1.0

5 changes: 4 additions & 1 deletion visualiser/generators/okitGenerator.py
Original file line number Diff line number Diff line change
@@ -409,7 +409,10 @@ def renderDynamicRoutingGateway(self, dynamic_routing_gateway):
# ---- Compartment Id
self.jinja2_variables["compartment_id"] = self.formatJinja2IdReference(self.standardiseResourceName(self.id_name_map[dynamic_routing_gateway['compartment_id']]))
# ---- Virtual Cloud Network OCID
self.jinja2_variables["vcn_id"] = self.formatJinja2IdReference(self.standardiseResourceName(self.id_name_map[dynamic_routing_gateway['vcn_id']]))
if dynamic_routing_gateway.get('vcn_id', '') != '':
self.jinja2_variables["vcn_id"] = self.formatJinja2IdReference(self.standardiseResourceName(self.id_name_map[dynamic_routing_gateway['vcn_id']]))
else:
self.removeJinja2Variable('vcn_id')
# ---- Display Name
self.addJinja2Variable("display_name", dynamic_routing_gateway["display_name"], standardisedName)
# --- Optional
2 changes: 2 additions & 0 deletions visualiser/templates/terraform/dynamic_routing_gateway.jinja2
Original file line number Diff line number Diff line change
@@ -18,9 +18,11 @@ locals {
{{ resource_name }}_id = oci_core_drg.{{ resource_name }}.id
}

{% if vcn_id is defined %}
# ------ Create DRG Attachment
resource "oci_core_drg_attachment" "{{ resource_name }}DRGAttachment" {
drg_id = local.{{ resource_name }}_id
vcn_id = {{ vcn_id }}
display_name = {{ display_name | safe }}
}
{% endif %}