Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in error properties name #104

Merged
merged 1 commit into from
Sep 15, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions okitweb/static/okit/js/okit_designer.js
Original file line number Diff line number Diff line change
Expand Up @@ -789,7 +789,7 @@ function displayValidationResults(results) {
d3.select(d3Id(error.id)).attr('fill', fill);
});
tr.on('click', () => {
error_propeties.push(error.element);
error_properties.push(error.element);
d3.select(d3Id(error.id + '-svg')).on("click")();
$('#toggle_properties_button').click();
});
Expand Down Expand Up @@ -819,7 +819,7 @@ function displayValidationResults(results) {
d3.select(d3Id(warning.id)).attr('fill', fill);
});
tr.on('click', () => {
warning_propeties.push(warning.element);
warning_properties.push(warning.element);
d3.select(d3Id(warning.id + '-svg')).on("click")();
$('#toggle_properties_button').click();
});
Expand Down
12 changes: 6 additions & 6 deletions okitweb/static/okit/js/okit_designer_properties.js
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ function setDescendantProp(obj, desc, value) {
return obj[arr[0]] = value;
}

let error_propeties = [];
let warning_propeties = [];
let error_properties = [];
let warning_properties = [];

function loadPropertiesSheet(json_element) {
console.log('Loading Properties');
Expand Down Expand Up @@ -184,15 +184,15 @@ function loadPropertiesSheet(json_element) {
d3.select(d3Id("optional_properties")).attr("open", "open");
}
// Check for Errors & Warnings
for (let property_name of error_propeties) {
for (let property_name of error_properties) {
$(jqId(property_name)).addClass('okit-error');
$(jqId(property_name)).focus();
}
error_propeties = [];
for (let property_name of warning_propeties) {
error_properties = [];
for (let property_name of warning_properties) {
$(jqId(property_name)).addClass('okit-warning');
}
warning_propeties = [];
warning_properties = [];
// Set up Multi Select boxes to toggle select
//$("select[multiple] option").mousedown(function() {let $self = $(this); $self.prop('selected', !$self.prop('selected')); return false;});
console.log();
Expand Down
4 changes: 2 additions & 2 deletions okitweb/static/okit/query/oci/js/okit_query.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ class OkitOCIQuery {

query(request = null, complete_callback) {
this.complete_callback = complete_callback;
if (request && request !== null) {
if (request) {
for (const [i, region] of this.regions.entries()) {
console.info(`${i} - Processing Selected Region : ${region}`);
let region_request = JSON.clone(request);
Expand All @@ -31,7 +31,7 @@ class OkitOCIQuery {
}

isComplete() {
if (this.complete_callback && this.complete_callback !== null) {
if (this.complete_callback) {
console.info(this.region_query_count);
for (let key of Object.keys(this.region_query_count)) {
if (this.region_query_count[key] > 0) {
Expand Down