Skip to content

Commit

Permalink
fix: code scanning issues #688, #689, #690, #691, #692, #693, #694
Browse files Browse the repository at this point in the history
  • Loading branch information
toxophilist committed Aug 22, 2024
1 parent 667e588 commit 24f922d
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions okitweb/okitWebDesigner.py
Original file line number Diff line number Diff line change
Expand Up @@ -407,7 +407,6 @@ def designer(target):
@bp.route('/panel/templates', methods=(['GET']))
def templates_panel():
target = request.args.get('target', default='')
logger.info(f'Template target {target}')
# ref_arch_root = os.path.join(bp.static_folder, 'templates', 'reference_architecture')
ref_arch_root = os.path.join(current_app.instance_path, 'templates', 'reference_architecture', target)
ref_arch_templates = dir_to_json(ref_arch_root, current_app.instance_path, 'children', 'templates')
Expand Down Expand Up @@ -588,8 +587,6 @@ def valueproposition(sheet):

@bp.route('/generate/<string:language>/<string:destination>', methods=(['GET', 'POST']))
def generate(language, destination):
logger.info('Language : {0:s} - {1:s}'.format(str(language), str(request.method)))
logger.info('Destination : {0:s} - {1:s}'.format(str(destination), str(request.method)))
if request.method == 'POST':
logger.debug('JSON : {0:s}'.format(str(request.json)))
use_vars = request.json.get("use_variables", True)
Expand Down Expand Up @@ -640,15 +637,12 @@ def generate(language, destination):
logger.exception(e)
return 'Failed to generate file', 500
else:
logger.info(f'Returning /tmp/okit-{language}.zip')
return send_from_directory('/tmp', "okit-{0:s}.zip".format(str(language)), mimetype='application/zip', as_attachment=True)


# TODO: Delete
@bp.route('/saveas/<string:savetype>', methods=(['POST']))
def saveas(savetype):
logger.info('Save Type : {0:s} - {1:s}'.format(str(savetype), str(request.method)))
logger.debug('JSON : {0:s}'.format(str(request.json)))
if request.method == 'POST':
try:
filename = '{0!s:s}.json'.format(request.json['title'].replace(' ', '_').lower())
Expand Down Expand Up @@ -712,17 +706,14 @@ def dropdownData(profile, region):
if request.method == 'GET':
if os.path.exists(profile_dropdown_file):
dropdown_file = profile_dropdown_file
logger.info(f'Loading Dropdown file {dropdown_file}')
dropdown_json = readJsonFile(dropdown_file)
else:
dropdown_file = shipped_dropdown_file
logger.info(f'Loading Dropdown file {dropdown_file}')
dropdown_json = readJsonFile(dropdown_file)
dropdown_json["shipped"] = True
dropdown_json["default"] = True
return dropdown_json
elif request.method == 'POST':
logger.info(f'Saving Dropdown file {profile_dropdown_file}')
writeJsonFile(request.json, profile_dropdown_file)
return request.json
else:
Expand Down

0 comments on commit 24f922d

Please sign in to comment.