test: block the malware detection unit test from reaching network #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
tromai
approved these changes
Jan 5, 2025
art1f1c3R
approved these changes
Jan 6, 2025
benmss
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
detect_malicious_metadatacheck is expected toFAILforpkg:pypi/zlibxjsonby running the heuristics, but a false negative has been introduced after the addition of the wheel presence heuristic. The unit test was passing because if the unit test was able to access the OSV knowledge base, it would identify the package as a known malware without running the heuristics. However, to ensure unit tests remain offline, network access is intentionally blocked and because of that the check passes. There is a TODO to fix this regression after adding better code-based heuristics.This PR modifies the API URL configurations to make them compatible with offline unit tests, ensuring they work without requiring network access.